Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apidiff does not understand nint and nuint for the NET profile #13669

Closed
spouliot opened this issue Jan 11, 2022 · 0 comments · Fixed by #14965
Closed

apidiff does not understand nint and nuint for the NET profile #13669

spouliot opened this issue Jan 11, 2022 · 0 comments · Fixed by #14965
Assignees
@rolfbjarne
Labels
enhancement The issue or pull request is an enhancement
Milestone
.NET 6

Comments

@spouliot
Copy link
Contributor

E.g. IntPtr is used instead of nint

Added methods:

	public bool GetArray (IntPtr idx, out CGPDFArray array);

The tooling does not know about the recent [NativeInteger] attribute
https://github.com/dotnet/roslyn/blob/main/docs/features/NativeIntegerAttribute.md
@mandel-macaque mandel-macaque added the enhancement The issue or pull request is an enhancement label Jan 18, 2022
@mandel-macaque mandel-macaque added this to the .NET 6 milestone Jan 18, 2022
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue May 10, 2022
@rolfbjarne
[apidiff} Switch to getting mono-api-[info|html] from rolfbjarne/api-…
3b6386f 
…tools.

Switch to getting mono-api-[info|html] from a newly created repository we
control and where we can easily fix issues, since mono/mono isn't getting many
fixes anymore. In the past I know I've been reluctant to look at these tools,
just because of the hassle of setting things up to debug, and then the
paperwork to get the fixes in mono/mono, and then backported to the branch
where we need them.

This repo has a few other benefits:

* The tools are built using normal projects, which means they're easy to debug
  in an IDE (mono/mono's code has generated project files, which used in-tree versions
  of the BCL, and it got quite complex quite fast).
* One fewer dependency on the mono archive, so we're getting closed to be able
  to drop it completely when we drop support for legacy Xamarin.
* xamarin#13669 is already fixed there.
* It contains a few other misc fixes.

Fixes xamarin#13669.
@rolfbjarne rolfbjarne mentioned this issue May 10, 2022
Merged
rolfbjarne added a commit that referenced this issue May 11, 2022
@rolfbjarne
[apidiff] Switch to getting mono-api-[info|html] from rolfbjarne/api-…
adb5650 
…tools. (#14965)

Switch to getting mono-api-[info|html] from a newly created repository we
control and where we can easily fix issues, since mono/mono isn't getting many
fixes anymore. In the past I know I've been reluctant to look at these tools,
just because of the hassle of setting things up to debug, and then the
paperwork to get the fixes in mono/mono, and then backported to the branch
where we need them.

This repo has a few other benefits:

* The tools are built using normal projects, which means they're easy to debug
  in an IDE (mono/mono's code has generated project files, which used in-tree versions
  of the BCL, and it got quite complex quite fast).
* One fewer dependency on the mono archive, so we're getting closed to be able
  to drop it completely when we drop support for legacy Xamarin.
* #13669 is already fixed there.
* It contains a few other misc fixes.

Fixes #13669.
@ghost ghost locked as resolved and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rolfbjarne rolfbjarne

Labels
enhancement The issue or pull request is an enhancement
Projects
None yet
Milestone
.NET 6
3 participants
@rolfbjarne @spouliot @mandel-macaque