Skip to content

Commit

Permalink
[Foundation] Remove the NSObject.[MonoTouchAssembly|MonoMacAssembly] …
Browse files Browse the repository at this point in the history
…fields in .NET. (#13681)

They're deprecated, because there's a better alternative (NSObject.PlatformAssembly).
  • Loading branch information
rolfbjarne authored Jan 12, 2022
1 parent 10ad084 commit 32561da
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/Foundation/NSObject.iOS.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public partial class NSObject : INativeObject
{
#if !COREBUILD

#if !XAMCORE_4_0 && !WATCH
#if !NET && !WATCH
[Obsolete ("Use 'PlatformAssembly' for easier code sharing across platforms.")]
public readonly static Assembly MonoTouchAssembly = typeof (NSObject).Assembly;
#endif
Expand Down
2 changes: 1 addition & 1 deletion src/Foundation/NSObject.mac.cs
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ public partial class NSObject : INativeObject
static IntPtr un = Dlfcn.dlopen (Constants.UserNotificationsLibrary, 1);
static IntPtr il = Dlfcn.dlopen (Constants.iTunesLibraryLibrary, 1);

#if !XAMCORE_4_0
#if !NET
[Obsolete ("Use PlatformAssembly for easier code sharing across platforms.")]
public static readonly Assembly MonoMacAssembly = typeof (NSObject).Assembly;
#endif
Expand Down

5 comments on commit 32561da

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ [CI Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

API Current PR diff

ℹ️ API Diff (from PR only) (please review changes)

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

Generator diff

Generator Diff (no change)

Packages generated

View packages

Test results

4 tests failed, 231 tests passed.

Failed tests

  • monotouch-test/Mac [dotnet]/Debug [dotnet]: TimedOut (Execution timed out after 1200 seconds.
    Test run crashed)
  • monotouch-test/Mac [dotnet]/Debug (static registrar) [dotnet]: TimedOut (Execution timed out after 1200 seconds.
    Test run crashed)
  • dont link/Mac Catalyst [dotnet]/Debug [dotnet]: TimedOut (Execution timed out after 1200 seconds.
    No test log file was produced)
  • trimmode copy/Mac Catalyst [dotnet]/Debug [dotnet]: Failed (Test run crashed (exit code: 134).
    Tests run: 11 Passed: 6 Inconclusive: 0 Failed: 0 Ignored: 5)

Pipeline on Agent XAMMINI-065.BigSur'
[Foundation] Remove the NSObject.[MonoTouchAssembly|MonoMacAssembly] fields in .NET. (#13681)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on M1 - Mac Big Sur (11.5) 🔥

Mac tests were not packaged.

Pipeline on Agent
[Foundation] Remove the NSObject.[MonoTouchAssembly|MonoMacAssembly] fields in .NET. (#13681)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests iOS (no summary found). 🔥

Result file D:\a\1\s\Reports\TestSummary-iOS64\TestSummary.md not found.

Pipeline on Agent
[Foundation] Remove the NSObject.[MonoTouchAssembly|MonoMacAssembly] fields in .NET. (#13681)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on Mac Catalina (10.15) 🔥

Mac tests were not packaged.

Pipeline on Agent
[Foundation] Remove the NSObject.[MonoTouchAssembly|MonoMacAssembly] fields in .NET. (#13681)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests tvOS (no summary found). 🔥

Result file D:\a\1\s\Reports\TestSummary-tvos\TestSummary.md not found.

Pipeline on Agent
[Foundation] Remove the NSObject.[MonoTouchAssembly|MonoMacAssembly] fields in .NET. (#13681)

Please sign in to comment.