Fix badge view default text "0"

[FedericoNembrini]

Description of Bug

BadgeView default Text value is never set.

The Text property has a default value of 0, but it is never set to the actual label. This prevents the BadgeView from being displayed if it is bound to a property with a value of 0 and AutoHide is set to false.

Issues Fixed

• Fixes [Bug] The initial value of property couldn't display correctly on xct:BadgeView when using data binding. #1900

Before

After

PR Checklist

• Has a linked Issue, and the Issue has been approved
• Has tests (if omitted, state reason in description)
• Has samples (if omitted, state reason in description)
• Rebased on top of main at time of PR
• Changes adhere to coding standard
• Updated documentation

[FedericoNembrini]

@microsoft-github-policy-service agree

[bijington]

This looks good to me. I haven't had a chance to test with AutoHide set to true, did you manage to test and make sure that functionality still works?

[FedericoNembrini]

AutoHide default value is set to true

XamarinCommunityToolkit/src/CommunityToolkit/Xamarin.CommunityToolkit/Views/BadgeView/BadgeView.shared.cs

Lines 54 to 59 in e7c0c80

	/// <summary>
	/// Backing BindableProperty for the <see cref="AutoHide"/> property.
	/// </summary>
	public static BindableProperty AutoHideProperty =
	BindableProperty.Create(nameof(AutoHide), typeof(bool), typeof(BadgeView), defaultValue: true,
	propertyChanged: OnAutoHideChanged);

And BadgeIndicatorContainer visibility is set to false

XamarinCommunityToolkit/src/CommunityToolkit/Xamarin.CommunityToolkit/Views/BadgeView/BadgeView.shared.cs

Lines 286 to 291 in e7c0c80

	static Grid CreateIndicatorContainerElement() => new Grid
	{
	HorizontalOptions = LayoutOptions.Start,
	VerticalOptions = LayoutOptions.Start,
	IsVisible = false
	};

In my test case, the second label is wrapped in a BadgeView and AutoHide is true. When the binded text is changed it is always called UpdateVisibilityAsync.

XamarinCommunityToolkit/src/CommunityToolkit/Xamarin.CommunityToolkit/Views/BadgeView/BadgeView.shared.cs

Lines 199 to 206 in e7c0c80

	static async void OnTextChanged(BindableObject bindable, object oldValue, object newValue)
	{
	if (bindable is BadgeView badgeView)
	{
	badgeView.UpdateLayout();
	await badgeView.UpdateVisibilityAsync();
	}
	}

As a result, the default behaviour of AutoHide remains unchanged

[bijington]

@FedericoNembrini Thank you for this submission!