This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
fix crash on iOS 8 when entering-existing carousel caused by memory leak #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also noticed memory leaks and opened an issue (#16). Is Xamarin even actively maintaining this project any more? |
|
Since this project is closed but I need to use it, I have reworked this PR as a Patch that can be used by just copying this code into your Client project |
This was referenced Jan 29, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have in my app a carouselView with 4 images in it. On iOS 8.1 if I enter, exit and re-enter I get a crash. This doesn't happen on iOS10. Not tested on iOS9