This repository has been archived by the owner on May 15, 2024. It is now read-only.
Fixes hang waiting for cancelled TextToSpeech #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think build failures were related to my changes. Let me know if I'm wrong |
jfversluis
approved these changes
Jan 18, 2022
1 task
1 task
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
There's a bug in Android TTS that if you cancel quickly after starting TTS,
SpeakAsyncwill never return. This is because theCancellationTokenwas cancelled before theTaskCompletionSourcewas being assigned, so awaiting theTaskCompletionSourcewould wait forever. To fix, I moved the creation of theTaskCompletionSourcebefore we register with theCancellationTokenBugs Fixed
Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.
API Changes
None
Behavioral Changes
Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.
PR Checklist
mainat time of PR