This repository has been archived by the owner on May 15, 2024. It is now read-only.
Rework the "picker" results to correctly manage files #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pictos
previously approved these changes
Dec 1, 2020
| return resolved; | ||
| } | ||
| else if (uri.Scheme.Equals("file", StringComparison.OrdinalIgnoreCase)) | ||
| { |
There was a problem hiding this comment.
how about moving those strings to constants?
There was a problem hiding this comment.
Yup. You got me. I am always pestering people abut these magic strings. I will hang my head in shame and walk to the nearest corner.
There was a problem hiding this comment.
It's ok that you like to type the same string over and over again 🤣
- Mime types - Extensions - Changed property type of ShareMultipleFilesRequest.Files to be a List<T> for consistency
| <intent> | ||
| <action android:name="android.intent.action.DIAL" /> | ||
| <data android:scheme="tel" /> | ||
| </intent> | ||
| <!-- MediaPicker --> |
There was a problem hiding this comment.
This needs to be added to documentation :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR solves a few issues.
Because we use an intermediate activity, this means that the URI almost immediately becomes invalid.
To solve for this, we have to resolve the physical path of the picked file. Many providers have a way to retrieve the physical path, or the path is known based on the type of content URI.
This might be because there are no permissions, or the file only exists as a stream from a file provider.
In this case, we need to copy the file to a local location.
This might be a Google docs spreadsheet which is not a real file format.
To solve this, we detect the virtual and then ask the provider what formats are supported. We then use that format and open the stream.
This PR also changes a few things in the code that overlap with the fixes.
IsIntentSupportedmethod on Android.List<T>forShareMultipleFilesRequest.Filesfor consistency.Bugs Fixed
API Changes
None visible.
Behavioral Changes
This PR will make sure all the
FileResultinstances point to a physical file location after a picker operation.PR Checklist
mainat time of PR