This repository has been archived by the owner on May 15, 2024. It is now read-only.
[Bug][Android] File Picker exception when using third-party file managers #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch xamarin:main into dimonovdd:main
This was referenced Oct 13, 2020
Merge xamarin:main into dimonovdd:main
|
Looks good, appreciate your contribution to the docs as well :) |
jamesmontemagno
previously approved these changes
Oct 15, 2020
|
@jamesmontemagno |
* main: [Enhancement] Share Multiple Files (xamarin#1445) [FilePicker] Add support for selecting PDF files (Issue 1404) (xamarin#1412) Subset of 1030 pr, easy to review (xamarin#1450) Add docs for ContinueUserActivity Add ContinueUserActivity impl for Universal App Links
|
I think we need to have a look at the comments on the issue before we merge. |
|
@dimonovdd should we also be removing the Looking at the docs, it appears that it just opens up the possibility, but doesn't to anything else. |
Yes, of course. I didn't notice |
mattleibow
approved these changes
Nov 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
To resolve the exception, you should add this permission:<uses-permission android:name="android.permission.MANAGE_DOCUMENTS" />PR corrected as described on #1444 (comment)
Bugs Fixed
Fixes #1444
PR Checklist
mainat time of PR