[Bug] Approximate location on Android 12 doesn't work correct.

[orikworld]

Description

Can not get the approximate location on android 12 because line (Permissions.EnsureGrantedAsync<Permissions.LocationWhenInUse>()) expected only permissions granted:

Essentials/Xamarin.Essentials/Geolocation/Geolocation.android.cs

Line 40 in 72dda32

await Permissions.EnsureGrantedAsync<Permissions.LocationWhenInUse>();

Steps to Reproduce

1. Select the approximate location in popup
2. Try to get permissions for locationInUse => Restricted
3. Try to get the approximate location => throw a exception

Expected Behavior

 Geolocation gets the approximate location on android 12

Actual Behavior

Geolocation throws a exception

Basic Information

• Version with issue:
• Platform Target Frameworks:
  • Android: 12 (API 31)

[SharpMobileCode]

I'm seeing the same issue as you when users select "Approximate" location. The permission status comes back as Restricted, which is expected. But when we perform a Geolocation.GetLocationAsync(request), a null result comes back instead of a Location.

I'm just taking a guess here looking at the code, but I think this line:

Essentials/Xamarin.Essentials/Permissions/Permissions.shared.cs

Line 28 in 72dda32

if (status != PermissionStatus.Granted)

might need to be checking for PermissionStatus.Restricted as well?

Current Code

if (status != PermissionStatus.Granted)
    throw new PermissionException($"{typeof(TPermission).Name} permission was not granted: {status}");

Proposed Change?

if (status != PermissionStatus.Granted && status != PermissionStatus.Restricted)
    throw new PermissionException($"{typeof(TPermission).Name} permission was not granted: {status}");

Thoughts anyone?

cc: @jfversluis

[jfversluis]

@aritchie I guess this might be something that came from #1937 ?

[jfversluis]

@SharpMobileCode I see you have a analysis and proposal already, would you be willing and able to put it in a PR? You should be able to then also test if it actually fixes it for you :)

[aritchie]

@jfversluis yup. I only changed the permission requests, not any of the gatekeeper methods. I just sent a PR for this: #1976

I would appreciate if the users in this issue test it please.

[SharpMobileCode]

I'll check it out this evening (CST) and will let you all know. Thank you!

[jfversluis]

Let me know if you got around to this @SharpMobileCode thanks!

[SharpMobileCode]

@jfversluis Thanks! Yeah, I pulled down the PR and was able to compile locally. But when I integrate the new binaries into the project I'm working on, I'm getting compile errors in my code saying that it can't find HapticFeedback and HapticFeedbackType from the new Essentials binary. Am I missing something?

[SharpMobileCode]

Okay, I've got it integrated into my app now (using project references instead) and it doesn't appear to work as expected. Currently running through the debugger trying to figure some stuff out. Thanks!

[SharpMobileCode]

Okay, now it seems that when the user selects "Approximate Location", the locationManager.RequestUpdates(provider, 0, 0, listener, looper); call does not seem to execute the listener. This causes

Essentials/Xamarin.Essentials/Geolocation/Geolocation.android.cs

Line 84 in c0ea6b0

var androidLocation = await tcs.Task;

to await indefinitely because:

Essentials/Xamarin.Essentials/Geolocation/Geolocation.android.cs

Line 91 in c0ea6b0

void HandleLocation(AndroidLocation location)

is never invoked from the listener. So it just kind of freezes there. However, if the user selects "Precise" location, then everything works as expected.

I've only ever used FusedLocationProviderClient natively for geolocation, so I'm not too familiar with LocationManager. I'll have to research this further. Any insight or experiences regarding this?

Thanks!

[jfversluis]

Thanks for working together on this with us @SharpMobileCode ! I'll look into this asap as well :)