Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent JSON parse error #827

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Prevent JSON parse error #827

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f64ec3
Prevent JSON parse error
TheJaredWilcurt Mar 9, 2021
703fc26
Update src/components/Table.vue
TheJaredWilcurt Mar 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Table.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1582,7 +1582,7 @@ export default {

initializeSort() {
const { enabled, initialSortBy, multipleColumns } = this.sortOptions;
const initSortBy = JSON.parse(JSON.stringify(initialSortBy));
const initSortBy = JSON.parse(JSON.stringify(initialSortBy || {}));
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If initialSortBy is undefined default to an empty object to prevent JSON.parse(undefined) error from throwing.


if (typeof enabled === 'boolean') {
this.sortable = enabled;
Expand Down