Add network toggle switch command to cli runtime #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove unused constant, replace with value from config for testability on testnet
XDapps
reviewed
Oct 28, 2024
apps/cli/src/index.ts
Outdated
| @@ -136,6 +136,22 @@ cli.action(async () => { | |||
| cli.outputHelp(); | |||
| continue; | |||
| } | |||
|
|
|||
| // Show help message if the user asks for it | |||
There was a problem hiding this comment.
Should we remove, or update this comment?
There was a problem hiding this comment.
Updated the comment, thanks !
XDapps
reviewed
Oct 28, 2024
|
|
||
| // Show help message if the user asks for it | ||
| if (command === 'toggle-switch-network') { | ||
| if(config.defaultNetworkName === "arbitrum"){ |
There was a problem hiding this comment.
Should this be arbitrumSepolia instead?
There was a problem hiding this comment.
I don't think it should.
If the current config's defaultNetworkName equals "arbitrum" we are currently using mainnet (default) so we switch to testnet, if not we switch back to mainnet.
There was a problem hiding this comment.
I understand now, I was thinking the config had already been changed but I follow now, thank you for the clarification!
XDapps
requested changes
Oct 28, 2024
| @@ -9,7 +9,7 @@ export async function isChallengeSubmitTime(): Promise<{isSubmitTime:boolean, cu | |||
| const lastChallengeTime = Number(currentChallenge.createdTimestamp); | |||
|
|
|||
| // Calculate the minimum time to submit an assertion | |||
| const minimumTimeToSubmit = lastChallengeTime + MINIMUM_SECONDS_BETWEEN_ASSERTIONS; | |||
| const minimumTimeToSubmit = lastChallengeTime + config.minSecondsBetweenChallenges; | |||
There was a problem hiding this comment.
I love how you moved this to the config file.
XDapps
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #188385836
Add dev cli command to toggle network switch:
toggle-switch-networkMoved min seconds between challenges constant to config so it can be changes for testnet tests.
Increase loopCount for finding missed assertions, this will return undefined if too many blocks have passed until the latest NodeConfirmed. On testnet after about 10 hours, mainnet will have more blocks passing so this will be a shorter time.
Tested locally, added dev logs to print current config, tested toggle between mainnet and testnet and run commands in between to confirm toggle works.
Built locally and testent challenger and operator on testnet mode while confirming nodes on mockrollup.