forked from kaktus40/cesium-sensors
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to work with Cesium 1.59 #1
Open
Flowm
wants to merge
77
commits into
xagriff:master
Choose a base branch
from
Flowm:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… properties in Cesium 1.8
I face an already known bug in Chrome here. The original bug is CesiumGS/cesium#7798 |
Hi xagriff. Since I can't see any practical use for the sensors I have no using it anymore. I think I could make some kind of calculations like viewshed or detections but as far I can see it is just a dead object. |
Changed defineProperties to Object.defineProperties. Changed czm_phong to new function signature with 3 parameters.
Cesium sensor volumes
Flowm
force-pushed
the
master
branch
2 times, most recently
from
December 25, 2022 23:18
6c8758c
to
037c681
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin fails in Cesium 1.59 with
RuntimeError: Fragment shader failed to compile. Compile log: ERROR: 0:2: 'czm_ellipsoid' : syntax error
czm_ellipsoid
and thusczm_ellipsoid.inverseRadii
were replaced by constants in CesiumGS/cesium#7944.Use the new
czm_ellipsoidInverseRadii
instead to make the plugin work with Cesium 1.59.