chore: bump hashbrown to v0.13 && bump MSRV #250
Conversation
Signed-off-by: TennyZhuang <[email protected]>
|
This PR increases the MSRV beyond what I'd like to do right now in addition to not updating other MSRV-related datapoints such as the readme. Is that a requirement of the |
TennyZhuang
changed the title
|
@xacrimon Yes, hashbrown also bumped their MSRV to Rust 1.61, I guess it's acceptable while the stable version has been bumped to 1.66. |
|
Hello, Rust 1.68 is now stable, and Rust 1.61 has been out since May 2022. Would it be possible to merge this and release it? We're getting duplicate hashbrown dependency versions due to dashmap in Boa :( it would be nice to get a consistent versioning across the crate. |
…2685) After this, we are still waiting for `indexmap` & `dashmap` to provide the new `hashbrown` to reduce duplicate dependencies, and for `criterion` to remove `clap` and release a new version. We're also waiting for a new version of `icu_datagen` that bumps the `zip` dependency to avoid a potential vulnerability. Ideally, they would also bump the `simple_logger` dependency, which is pretty outdated. In any case, `simple_logger` still uses an unmaintained `atty` dependency. Relevant issues: - xacrimon/dashmap#250 - unicode-org/icu4x#3150 - bheisler/criterion.rs#599 - borntyping/rust-simple_logger#74
|
Hi @xacrimon, can this PR get merged? |
|
FWIW, hashbrown 0.14 is out now, although that further requires Rust 1.64. |
|
I'd like to bump it to 0.14 in another PR, but I guess the PR can be merged first. |
Signed-off-by: TennyZhuang [email protected]