StratifiedSample software eng edits, reorder, testing #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smishr
added
enhancement
|
Have overhauled the src of StratifiedSample, still have to write correct testing suite |
| @@ -178,75 +179,158 @@ end | |||
| StratifiedSample <: AbstractSurveyDesign | |||
|
|
|||
| Survey design sampled by stratification. | |||
|
|
|||
There was a problem hiding this comment.
I think the doc should have an example.
There was a problem hiding this comment.
how many lines of output must be copied into doctring?
There was a problem hiding this comment.
I have added and fixed the jldoctests. They have to be spaced right to margin, no tabs before to be displayed like a code block
Codecov Report
@@ Coverage Diff @@
## design_update #95 +/- ##
=================================================
+ Coverage 43.93% 47.16% +3.23%
=================================================
Files 15 15
Lines 528 583 +55
=================================================
+ Hits 232 275 +43
- Misses 296 308 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This was referenced Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the other PR for
SimpleRandomSample, incorporates type checking and better if-else ladder forStratifiedSample