Exhaustively testing SimpleRandomSample, software eng improvements #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Domain stratified sample merge into Shikhar design_update branch
smishr
added
enhancement
|
@ayushpatnaikgit After the latest commits, it passes |
Co-authored-by: Ayush Patnaik <[email protected]>
Co-authored-by: Ayush Patnaik <[email protected]>
Co-authored-by: Ayush Patnaik <[email protected]>
Co-authored-by: Ayush Patnaik <[email protected]>
Co-authored-by: Ayush Patnaik <[email protected]>
Co-authored-by: Ayush Patnaik <[email protected]>
Co-authored-by: Ayush Patnaik <[email protected]>
Co-authored-by: Ayush Patnaik <[email protected]>
This was referenced Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been making lots of software engineering improvements and if-else ladder type changes as we move towards 0.2 package release. This PR also attempts to continue and resolve #75 #67 #70 #64.
Specifically,
SimpleRandomSampleis being exhaustively tested and reformatted, with more type checking and intelligent parsing behaviour.