Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor corrections #63

Merged
merged 21 commits into from
Oct 16, 2022
Merged

Conversation

iuliadmtru
Copy link
Contributor

@iuliadmtru iuliadmtru commented Oct 15, 2022

[General] Remove duplicate code and unnecessary comments and rephrase comments, error messages and docstrings where necessary.

[SurveyDesign.jl] Slightly change the structure of if-else statements and do the type check for weights and probs at the beginning of the constructor only. Generalise Base.show to work for any AbstractSurveyDesign subtype.

Edit
[show.jl] Move the Base.show method to a separate file and implement a new function, printinfo, that prints data in the format "title: content". show uses this function to print the survey design information.

@codecov-commenter
Copy link

Codecov Report

Merging #63 (86d139d) into design_update (d1bf631) will increase coverage by 4.99%.
The diff coverage is 18.08%.

@@                Coverage Diff                @@
##           design_update      #63      +/-   ##
=================================================
+ Coverage          31.55%   36.55%   +4.99%     
=================================================
  Files                 13       14       +1     
  Lines                450      383      -67     
=================================================
- Hits                 142      140       -2     
+ Misses               308      243      -65     
Impacted Files Coverage Δ
src/ht.jl 0.00% <0.00%> (ø)
src/show.jl 0.00% <0.00%> (ø)
src/svyby.jl 0.00% <ø> (ø)
src/svydesign.jl 38.59% <ø> (ø)
src/svymean.jl 11.11% <5.55%> (+0.96%) ⬆️
src/svytotal.jl 19.51% <25.00%> (ø)
src/SurveyDesign.jl 30.48% <33.33%> (+13.61%) ⬆️
src/svyquantile.jl 52.38% <100.00%> (+4.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ayushpatnaikgit ayushpatnaikgit merged commit ffea267 into xKDR:design_update Oct 16, 2022
@iuliadmtru iuliadmtru deleted the minor_corrections branch October 16, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants