Improved SRS Design with args error checking, better types #53
Conversation
|
@smishr can you check where the test is failing? |
| @@ -2,13 +2,13 @@ | |||
| function print_short(x) | |||
| # write floats in short form | |||
| if isa(x[1], Float64) | |||
| x = round.(x, sigdigits = 3) | |||
| x = round.(x, sigdigits=3) | |||
There was a problem hiding this comment.
I guess this is the formatter's doing. In that case, let's keep the style like this - without spaces around equal signs for argument values - but this should be a different PR. Also, this needs to be done in all the files in order to keep consistency.
There was a problem hiding this comment.
Yep the formatter reduces the space around = signs
| weights = popsize ./ sampsize | ||
| popsize = first(popsize) |> UInt | ||
| else | ||
| error("If popsize not given then either sampling weights or sampling probabilities must be given") |
There was a problem hiding this comment.
"If popsize is not given ..."
| data[!, :probs] = probs | ||
| # add frequency weights column to `data` | ||
| data[!, :weights] = 1 ./ data[!, :probs] | ||
| else # else weights were specified |
There was a problem hiding this comment.
Remove "else" from the comment
…nto design_update
Codecov Report
@@ Coverage Diff @@
## design_update #53 +/- ##
==================================================
- Coverage 55.26% 43.73% -11.54%
==================================================
Files 12 12
Lines 266 327 +61
==================================================
- Hits 147 143 -4
- Misses 119 184 +65
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Shall we merge this? |
yes |
No description provided.