Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fpc, fix svytotal and svymean #48

Merged
merged 16 commits into from
Aug 31, 2022

Conversation

smishr
Copy link
Contributor

@smishr smishr commented Aug 29, 2022

29.08.22 5pm work

@iuliadmtru
Copy link
Contributor

I pushed on your fork because I didn't know how else to push these changes, I hope that's ok. Apart from making some style modifications and some reorganisation, I integrated the previous commit in this PR.

.gitignore Outdated Show resolved Hide resolved
@iuliadmtru
Copy link
Contributor

@ayushpatnaikgit Can you take a look at why the CI tests fail?

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2022

Codecov Report

Merging #48 (8761cf6) into design_update (841bf45) will decrease coverage by 3.03%.
The diff coverage is 38.18%.

@@                Coverage Diff                @@
##           design_update      #48      +/-   ##
=================================================
- Coverage          61.83%   58.80%   -3.04%     
=================================================
  Files                 11       11              
  Lines                283      250      -33     
=================================================
- Hits                 175      147      -28     
+ Misses               108      103       -5     
Impacted Files Coverage Δ
src/dimnames.jl 100.00% <ø> (ø)
src/svyboxplot.jl 50.00% <ø> (ø)
src/svydesign.jl 45.61% <ø> (ø)
src/svyglm.jl 82.97% <ø> (ø)
src/svyhist.jl 94.73% <ø> (ø)
src/svyplot.jl 50.00% <ø> (-50.00%) ⬇️
src/svyquantile.jl 81.81% <ø> (ø)
src/SurveyDesign.jl 23.88% <19.51%> (+1.88%) ⬆️
src/svytotal.jl 77.77% <87.50%> (-14.53%) ⬇️
src/svymean.jl 100.00% <100.00%> (+48.71%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

iuliadmtru added a commit to iuliadmtru/Survey.jl that referenced this pull request Aug 30, 2022
@iuliadmtru
Copy link
Contributor

@ayushpatnaikgit Can you take a look at why the CI tests fail?

Now it looks like the tests actually passed. Before it showed a weird error for me which I couldn't understand and I can't access it again to show it to you.

@ayushpatnaikgit ayushpatnaikgit merged commit 3ba241a into xKDR:design_update Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants