-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all data samples provided in R and update load_data
#35
Conversation
We also need a separate documentation file, perhaps called “Sample datasets”. |
Perhaps, we should
@greimel what do you think? |
Co-authored-by: Ayush Patnaik <[email protected]>
Now all tabs are consistent
Codecov Report
@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 65.82% 66.25% +0.42%
==========================================
Files 8 8
Lines 158 160 +2
==========================================
+ Hits 104 106 +2
Misses 54 54
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Have you checked that it is permitted to make these files available here? |
Should be fine since we are using the same license as the R package that contains these files. But I'll verify this with Thomas Lumley. |
@iuliadmtru can you make these changes in a new PR? |
... see my suggestion in xKDR#35
load_data
now works for general file names. I added all the datasets provided by the R package, downloaded from here: https://github.com/cran/survey/tree/master/data and converted to CSV.