Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all data samples provided in R and update load_data #35

Merged
merged 3 commits into from
Aug 9, 2022

Conversation

iuliadmtru
Copy link
Contributor

load_data now works for general file names. I added all the datasets provided by the R package, downloaded from here: https://github.com/cran/survey/tree/master/data and converted to CSV.

src/example.jl Outdated Show resolved Hide resolved
@ayushpatnaikgit
Copy link
Member

We also need a separate documentation file, perhaps called “Sample datasets”.
This should contain documentation about all the sample datasets.

@ayushpatnaikgit
Copy link
Member

Perhaps, we should

  1. Change the name of the folder from assets to sample_datasets. This seems apt since we are reading all the .csv files from the folder, and that means we won't have another other kinds of assets.
  2. Change the filename containing the load_dataset function from example.jl to sample_datasets.jl or load_datasets.jl.

@greimel what do you think?

iuliadmtru and others added 2 commits August 8, 2022 20:36
Co-authored-by: Ayush Patnaik <[email protected]>
Now all tabs are consistent
@codecov-commenter
Copy link

Codecov Report

Merging #35 (d7822ae) into main (f4dc08f) will increase coverage by 0.42%.
The diff coverage is 100.00%.

❗ Current head d7822ae differs from pull request most recent head 0653787. Consider uploading reports for the commit 0653787 to get more accurate results

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   65.82%   66.25%   +0.42%     
==========================================
  Files           8        8              
  Lines         158      160       +2     
==========================================
+ Hits          104      106       +2     
  Misses         54       54              
Impacted Files Coverage Δ
src/example.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@greimel
Copy link
Contributor

greimel commented Aug 8, 2022

Have you checked that it is permitted to make these files available here?

@ayushpatnaikgit
Copy link
Member

Have you checked that it is permitted to make these files available here?

Should be fine since we are using the same license as the R package that contains these files. But I'll verify this with Thomas Lumley.

@ayushpatnaikgit
Copy link
Member

Perhaps, we should

1. Change the name of the folder from `assets` to `sample_datasets`. This seems apt since we are reading all the `.csv` files from the folder, and that means we won't have another other kinds of assets.

2. Change the filename containing the `load_dataset` function from `example.jl` to `sample_datasets.jl` or `load_datasets.jl`.

@greimel what do you think?

@iuliadmtru can you make these changes in a new PR?

@ayushpatnaikgit ayushpatnaikgit merged commit 76bc8b8 into xKDR:main Aug 9, 2022
greimel added a commit to greimel/Survey.jl that referenced this pull request Aug 9, 2022
... see my suggestion in xKDR#35
@greimel greimel mentioned this pull request Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants