New data structures to support multiple replicate methods. #297
Conversation
adding a new abstract type `InferenceMethod`.
|
The main crux of the code has been added; now I'll work on the documentation and modifying the tests. |
inference method `JackknifeReplicates` in `jackknife_variance`.
Codecov Report
@@ Coverage Diff @@
## main #297 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 242 245 +3
=========================================
+ Hits 242 245 +3
|
src/jackknife.jl
Outdated
| @@ -127,7 +127,7 @@ julia> jackknife_variance(:api00, weightedmean, rstrat) | |||
| # Reference | |||
| pg 380-382, Section 9.3.2 Jackknife - Sharon Lohr, Sampling Design and Analysis (2010) | |||
| """ | |||
| function jackknife_variance(x::Symbol, func::Function, design::ReplicateDesign) | |||
| function jackknife_variance(x::Symbol, func::Function, design::ReplicateDesign{JackknifeReplicates}) | |||
There was a problem hiding this comment.
It should just be called variance. There should be 2 dispatches.
variance(x::Symbol, func::Function, design::ReplicateDesign{JackknifeReplicates})variance(x::Symbol, func::Function, design::ReplicateDesign{BootstrapReplicates})
There was a problem hiding this comment.
Okay, but we don't have a variance method for BootstrapReplicates method yet, do we?
There was a problem hiding this comment.
Also, should I rewrite the mean function using multiple dispatch now, or should that be done as a separate PR?
There was a problem hiding this comment.
We should rewrite the functions now.
And we need a variance function for BootstrapReplicates. It's pretty simple, it's just the simple variable of the estimates.
There was a problem hiding this comment.
We should rewrite the functions now. And we need a variance function for
BootstrapReplicates. It's pretty simple, it's just the simple variable of the estimates.
Okay. Also, just to confirm: haven't we already implemented the variance function for BootstrapReplicates in the mean function in line 48 of this file?: https://github.com/xKDR/Survey.jl/blob/main/src/mean.jl
So we should probably get rid of this mean function right?
There was a problem hiding this comment.
Yes, we should get rid of it, and
function variance(x::Symbol, func::Function, design::ReplicateDesign{BootstrapReplicates})
...
variance = sum((θ̂t .- θ̂) .^ 2) / design.replicates
end
`variance` functions of `bootstrap.jl` and `jackknife.jl`.
`variance` function for bootstrap replicate.
This PR introduces a "replicate type" for every
ReplicateDesignobject. The purpose is mainly to help with multiple dispatch on difference replicate methods.We have introduced a new abstract type called
InferenceMethod, which will be a supertype for all inference types. For now, the package only supports two inference methods, which we've encoded by theBootstrapReplicatesandJackknifeReplicatesstructs.Relevant changes have been made to the
ReplicateDesignstruct to incorporate the new structure.Also, the
mean,totalandquantilefunctions have now been written using the genericvariancefunction. Sinceratiotakes two columns as it's arguments, it can't be implemented usingvarianceas of now (see #295 ).Closes #261