Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reverting and re-reverting mistakes, I can finally start a draft PR.
I started working on
show
. After considering a lot of options, this is the one that I think looks nicest and is in line with Julia standards:(I just changed my mind and now I think the vectors for
popsize
,sampsize
,weights
andprobs
should be on the same line as the names:instead of
but I will add this later)
Stratified:
Clustered:
Replicate:
There are a few things that I think we should discuss:
Should we mention the length of the vectors somewhere?
Cons:
Pro:
Should we keep our own pretty-printing or should we just rely on
IOContext
's:limit=>true, :compact=>true
?survey(io)
which is anIOContext
for pretty printing (it sets:limit
,:compact
and:displaysize
) but I couldn't get it to work properly. The display size just wasn't changing. So I went back to usingmakeshort
, which I modified to add square brackets around vectors and use…
instead of...
.