Remove extra docstrings and reorder methods for mean and total
#117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuliadmtru
changed the title
mean
Codecov Report
@@ Coverage Diff @@
## design_update #117 +/- ##
=================================================
- Coverage 49.79% 47.09% -2.70%
=================================================
Files 11 11
Lines 492 465 -27
=================================================
- Hits 245 219 -26
+ Misses 247 246 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
The documentation for |
iuliadmtru
changed the title
meanmean and total
ayushpatnaikgit
approved these changes
Dec 4, 2022
ayushpatnaikgit
approved these changes
Dec 4, 2022
|
Can you remove the function corresponding to #109? |
Removed strata means option for now. will reformat and add back at later stage.
smishr
approved these changes
Dec 5, 2022
There was a problem hiding this comment.
mean.jl look good. In total.jl docstring tests there are using Survey, Im not sure if they are required? @iuliadmtru @ayushpatnaikgit. otherwise looks good to merge
|
Removed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reordered the methods such that the first methods correspond to the main functionality (calculating the mean of a survey design variable) and the last methods correspond to the
byfunctionality (calculating the mean of a variable from a subpopulation). The very last method is not part of these, we should discuss on issue #109 what to do with it.After reordering, I removed the docstrings from all methods apart from the first one for each group and I added relevant examples for all methods inside that docstring.