Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial prototype to refactor custom_seasons API with Xarray SeasonGrouper() API [WIP] #715

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Initial prototype to refactor custom_seasons API with Xarray SeasonGrouper() API [WIP] #715

wants to merge 17 commits into from

Commits on Nov 12, 2024

  1. Add baseline unit tests 

    - Remove logic for requiring all 12 months to be used
    @tomvothecoder
    tomvothecoder committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    7716efc View commit details
    Browse the repository at this point in the history

  2. Add support for shifting months in seasons spanning calendar year

    @tomvothecoder
    tomvothecoder committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    ade02ba View commit details
    Browse the repository at this point in the history

  3. Add explaination of code for spanning months

    @tomvothecoder
    tomvothecoder committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    2a87cf0 View commit details
    Browse the repository at this point in the history

  4. Replace drop_incomplete_djf with drop_incomplete_seasons

    @tomvothecoder
    tomvothecoder committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    6b4ec65 View commit details
    Browse the repository at this point in the history

  5. Fix _drop_incomplete_seasons() adding dims to variables 

    - Add conditional that determines whether subsetting time coordinates is necessary with custom seasons
- Update docstrings for `season_config`
- Add tests
    @tomvothecoder
    tomvothecoder committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    fbad335 View commit details
    Browse the repository at this point in the history

  6. Add deprecation warning for "drop_incomplete_djf"

    @tomvothecoder
    tomvothecoder committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    4a896ba View commit details
    Browse the repository at this point in the history

  7. Fix tests

    @tomvothecoder
    tomvothecoder committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    9f496e5 View commit details
    Browse the repository at this point in the history

  8. Add test to cover missing line in _drop_incomplete_season

    @tomvothecoder
    tomvothecoder committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    7cb6910 View commit details
    Browse the repository at this point in the history

  9. Add clear error message when no complete seasons are found

    @tomvothecoder
    tomvothecoder committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    1cf4364 View commit details
    Browse the repository at this point in the history

  10. Update deprecation version for drop_incomplete_djf

    @tomvothecoder
    tomvothecoder committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    a050884 View commit details
    Browse the repository at this point in the history

  11. Update static time dim ref to CF interpreted dim key

    @tomvothecoder
    tomvothecoder committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    5ace7a8 View commit details
    Browse the repository at this point in the history

  12. Add drop_incomplete_djf back

    @tomvothecoder
    tomvothecoder committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    25e31f7 View commit details
    Browse the repository at this point in the history

  13. Move deprecation warning to inside DJF conditional

    @tomvothecoder
    tomvothecoder committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    2b47972 View commit details
    Browse the repository at this point in the history

  14. Update comment about .where concatenating time din

    @tomvothecoder
    tomvothecoder committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    05496ed View commit details
    Browse the repository at this point in the history

  15. Refactor logic for shifting months to use Xarray instead of Pandas 

    - Months are also shifted in the `_preprocess_dataset()` method now. Before months were being shifted twice, once when dropping incomplete seasons or DJF, and a second time when labeling time coordinates.
    @tomvothecoder
    tomvothecoder committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    0b6852f View commit details
    Browse the repository at this point in the history

  16. Add todo comments

    @tomvothecoder
    tomvothecoder committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    8d156c2 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Initial prototype using Xarray SeasonGrouper`

    @tomvothecoder
    tomvothecoder committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    2e736ca View commit details
    Browse the repository at this point in the history