Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add weight threshold option for spatial averaging #672

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add weight threshold option for spatial averaging #672

wants to merge 8 commits into from

Commits on Nov 21, 2024

  1. initial attempt at #531 (for spatial averaging)

    @pochedls @tomvothecoder
    pochedls authored and tomvothecoder committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    ea08915 View commit details
    Browse the repository at this point in the history

  2. cleanup print statement and complete code coverage

    @pochedls @tomvothecoder
    pochedls authored and tomvothecoder committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    127e711 View commit details
    Browse the repository at this point in the history

  3. Apply review suggestion. 

    Co-authored-by: Tom Vo <[email protected]>
    @pochedls @tomvothecoder
    pochedls and tomvothecoder committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    a2fee04 View commit details
    Browse the repository at this point in the history

  4. update required_weight argument (to minimum_weight)

    @pochedls @tomvothecoder
    pochedls authored and tomvothecoder committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    0602ea6 View commit details
    Browse the repository at this point in the history

  5. update tests for minimum_weight parameter

    @pochedls @tomvothecoder
    pochedls authored and tomvothecoder committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    1c5c3c1 View commit details
    Browse the repository at this point in the history

  6. Updates from code review 

    - Rename arg `minimum_weight` to `min_weight`
- Add `_get_masked_weights()` and `_validate_min_weight()` to `utils.py`
- Update `SpatialAccessor` to use `_get_masked_weights()` and `_validate_min_weight()`
- Replace type annotation `Optional` with `|`
- Extract `_mask_var_with_with_threshold()` from `_averager()` for readability
    @tomvothecoder
    tomvothecoder committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    636366b View commit details
    Browse the repository at this point in the history

  7. Fix TypeError for optional region arg in TypedDict

    @tomvothecoder
    tomvothecoder committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    82cbfe2 View commit details
    Browse the repository at this point in the history

  8. Remove rebase comment

    @tomvothecoder
    tomvothecoder committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    9331a02 View commit details
    Browse the repository at this point in the history