Improve depth(for picking) bits precision #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomlee-dev
force-pushed
the
feature/Improve_depth_bits_precision
branch
2 times, most recently
from
ce4641c
to
8312f16
Compare
|
I am not sure I have to target branch master or develop. This PR targets to master branch. please reply for this. |
|
Cheers for this. Will leave to @martin1cerny to review formally as it's his area. Would be good to understand the approach here, and how standard an approach this is - was 16bits not enough precision? Have you done much testing have you done on different browsers (webgl1 vs webgl2)? |
tomlee-dev
force-pushed
the
feature/Improve_depth_bits_precision
branch
2 times, most recently
from
86f557c
to
f1b12c8
Compare
tomlee-dev
force-pushed
the
feature/Improve_depth_bits_precision
branch
from
f1b12c8
to
ab9f9a0
Compare
|
@andyward oh! I just checked my code on webgl with chrome browser with execution parementer. ( --disable-webgl2 ) I think my change is only for the webgl 2 browser. for the webgl1 more research is needed. please cross check about this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications to obtain accurate values in 3D space (x,y,z) of a specific point on the mesh by clicking the mouse on the polygon mesh. This change is a correction to improve the existing inaccuracies.
I think this change resove the issue below.
#403