Skip to content

Commit

Permalink
Use plain string. Bytes string is a binja bug.
Browse files Browse the repository at this point in the history
  • Loading branch information
utkonos committed Oct 23, 2024
1 parent d7bf749 commit 7c0cf7f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion __init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def export_db(bv):
"""Export symbols and optionally comments from Binary Ninja to an x64dbg database."""
db = dict()
module = pathlib.Path(bv.file.original_filename)
outpath = bv.file.database.globals.get(b'x64dbg_db_save_path', pathlib.Path(bv.file.filename).parent)
outpath = bv.file.database.globals.get('x64dbg_db_save_path', pathlib.Path(bv.file.filename).parent)
dbext = 'dd{}'.format(bv.arch.address_size * 8)

if not (f := get_save_filename_input('Export database', dbext, f'{outpath}/{module.stem}.{dbext}')):
Expand Down
2 changes: 1 addition & 1 deletion plugin.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
"Windows",
"Linux"
],
"version": "2.0.3",
"version": "2.0.4",
"minimumBinaryNinjaVersion": 4526
}

1 comment on commit 7c0cf7f

@utkonos
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a bytes string for the global key name is actually a bug that was just fixed.
Vector35/binaryninja-api#6034

Please sign in to comment.