Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virtual templates #343

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add virtual templates #343

wants to merge 1 commit into from

Conversation

paulrobertlloyd
Copy link
Collaborator

@paulrobertlloyd paulrobertlloyd commented Oct 2, 2024

Fixes #290.

One issue I’ve discovered; includes and layouts directory are relative to the input directory. If you use a relative path (i.e. ../layouts), Eleventy will look in that folder and ignore the virtual templates (and/or their template paths).

To do

Possibly in a separate PR

  • Move all plugin code into /lib
  • Rename /lib to /src

@paulrobertlloyd
Copy link
Collaborator Author

paulrobertlloyd commented Oct 2, 2024

With a virtual template provided by the official Eleventy RSS plugin, do we want to bundle that with this plugin, or just let users opt into generating RSS feeds via that plugin (perhaps only providing a pointer to the instructions for doing so?).

Otherwise we might just be adding in a layer of needless complexity and obscurity, and possibly require even more configuration options that we’d need to pass around, document and maintain. @frankieroberto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant