Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add before and after links slots to footer #519

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Add before and after links slots to footer #519

merged 1 commit into from
Mar 26, 2024

Conversation

peteryates
Copy link
Member

@peteryates peteryates commented Mar 2, 2024 •
edited
Loading

These slots don't have any functionality but allow arbitrary html to be placed before/after the meta links.

  • Update the template so unnecessary whitespace isn't added when the slots aren't used
  • Make the testing a bit more robust

@netlify Netlify
Copy link

netlify bot commented Mar 2, 2024 •
edited
Loading

✅ Deploy Preview for govuk-components ready!

Name Link
🔨 Latest commit a32dc85
🔍 Latest deploy log https://app.netlify.com/sites/govuk-components/deploys/660303b16d6669000848f442
😎 Deploy Preview https://deploy-preview-519--govuk-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@peteryates peteryates force-pushed the allow-content-to-be-added-before-and-after-meta-links branch from 6a147c9 to 8b929c4 Compare March 5, 2024 19:38
Nitemaeric
Nitemaeric approved these changes Mar 26, 2024
View reviewed changes
Copy link

@Nitemaeric Nitemaeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's possible to get this in, we'll adopt this over our current custom implementation.

@peteryates peteryates marked this pull request as ready for review March 26, 2024 10:44
@peteryates peteryates force-pushed the allow-content-to-be-added-before-and-after-meta-links branch from 8b929c4 to 4aa6264 Compare March 26, 2024 10:44
@peteryates
Copy link
Member Author

@Nitemaeric sorry forgot about this, will get it merged and released today.

@frankieroberto this change look sensible to you?

frankieroberto
frankieroberto approved these changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@frankieroberto frankieroberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, if there's a need for this.

Could rename to content_before_meta_items just to be consistent?

@peteryates
Add before and after links slots to footer
a32dc85 
These slots don't have any functionality but allow arbitrary html to be
placed before/after the meta links
@peteryates peteryates force-pushed the allow-content-to-be-added-before-and-after-meta-links branch from 4aa6264 to a32dc85 Compare March 26, 2024 17:19
@peteryates peteryates added this pull request to the merge queue Mar 26, 2024
Merged via the queue into main with commit d4814e7 Mar 26, 2024
14 checks passed
@peteryates peteryates deleted the allow-content-to-be-added-before-and-after-meta-links branch March 26, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nitemaeric Nitemaeric Nitemaeric approved these changes

@frankieroberto frankieroberto frankieroberto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peteryates @frankieroberto @Nitemaeric