Add task list component #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The task list component displays all the tasks a user needs to do, and allows users to easily identify which ones are done and which they still need to do. Refs: alphagov/govuk-design-system/pull/1994
These are only needed to preview the guide until the task list is released and available in govuk-frontend. This commit can be dropped prior to merge.
✅ Deploy Preview for govuk-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
frankieroberto
requested changes
Aug 31, 2023
app/components/govuk_component/task_list_component/status_component.rb
Outdated
Show resolved
Hide resolved
app/components/govuk_component/task_list_component/item_component.rb
Outdated
Show resolved
Hide resolved
app/components/govuk_component/task_list_component/title_component.rb
Outdated
Show resolved
Hide resolved
Statuses can now be provided as strings, hash or with a block, offering complete flexibility. Co-authored-by: Frankie Roberto <[email protected]>
Update the classes to match the new ones upstream alphagov/govuk-frontend#3952
peteryates
force-pushed
the
add-task-list-component
branch
from
5a51db9
to
9386dc7
Compare
Now when these things are missing the containing elements aren't rendered at all
|
I've added support for There are some slight complications:
|
As I understand it, |
This change brings the behaviour of the task list more in line with the Nunjucks component. Now when there's no id_prefix param the ids of the statuses and tags are just numbered sequentially. If there's going to be more than one task list on a page they can have their prefixes set seprately so there's no ID clashes on the final rendered page. Co-authored-by: Frankie Roberto <[email protected]>
frankieroberto
approved these changes
Oct 31, 2023
|
@peteryates do we think there’s anything left to do on this or shall we merge it into the v5 branch? Do we still want to support an array of item objects as well as the block syntax, or is that an optional extra? |
|
I do plan on adding the array of items approach but I'm happy for that to follow as an enhancement, will get this merged later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the upcoming Task list component. It's built in a similar fashion to the summary list.
Tags can be added within statuses by calling
govuk_tagwithin the status, or plain text can be used.Final tasks