Issue #79 Read app configuration file once in app.py, and pass parame… #90
Conversation
…ters to worker for it to use what it needs. Issue #80 Change Globus groups file override indication to be indicated by a file name.
There was a problem hiding this comment.
@kburke the changes look good to me. The only comment I have is should we remove https://github.com/hubmapconsortium/uuid-api/blob/kburke/uuidSchemaRevisions/src/instance/globus-groups.json from github to avoid confusion? HuBMAP uses the groups json file from commons and we won't be passing in a new one via uuid-api. For SenNet and BCRF projects, they'll use a separate one, and they'll probably need to be committed to github.
|
@yuanzhou In the original writeup of issue #80, I put removing the file from Git based on @shirey comments during a meeting. But he later revised the issue to say, "L_ocating the GROUPS info file in the src/instance/ directory alongside app.cfg seems like the appropriate place for it, but ignored by git as app.cfg is_.", as archived in this comment. Based on that, I revised the description to say keep it in GitHub. But if his first instinct was to get it out of there, and that is yours also, maybe it should go. |
|
@yuanzhou and @kburke My preference would be to still track the SenNet (and eventual BCRF) |
|
I can push a file name change and app.py change. @shirey is there someone else who should align the content with the SenNet group info, rather than HuBMAP? It is unclear to me if description, name, displayname, etc. content referencing HM is important, or only the identfiers. |
…ters to worker for it to use what it needs. Issue #80 Change Globus groups file override indication to be indicated by a file name.
Sorry to put two cards in one PR, but the work was kind of muddle together.