Fix read endpoint to return results for identifiers without ancestors. #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirey
reviewed
May 26, 2022
src/uuid_worker.py
Outdated
| @@ -860,6 +860,8 @@ def getIdInfo(self, app_id): | |||
| for item in results: | |||
| if item['submission_id'] == None: | |||
| item.pop('submission_id') | |||
| if item['ancestor_ids'] == None: | |||
There was a problem hiding this comment.
@kburke Not clear- how are items created- is it possible that 'ancestor_id' doesn't exist at all in the dict?- if so will that cause line 863 to fail. Also, is it possible for 'ancestor_d`` to be an empty array?-- In which case it won't match the == None` comparison.
…tries before removing.
yuanzhou
approved these changes
May 31, 2022
shirey
pushed a commit
that referenced
this pull request
Mar 9, 2023
Fix read endpoint to return results for identifiers without ancestors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix read endpoint to return results for identifiers without ancestors.
#86