Yuanzhou/enable multithreading #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @kburke I'll proceed with this change, since Bill has tested on TEST. No action is needed from you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address #143, will need more testing work to ensure the MySQL connection intactness.
This multi-threading feature helps when there are lots of requests made to retrieve the uuids, BUT it doesn't solve any performance issue at the MySQL level. It's possible there's some sort of bottleneck lies in the queries when multiple tables are joined or we'll need to create B-Tree or Hash Indexes considering we have a large number of records currently.