Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove subclassing from uuid-api & database #141

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

kburke
Copy link

@kburke kburke commented Jan 24, 2024

Remove logic mapping Publication entities into Dataset entities, and support for annotation related to "subclassing". Revise ERD and database generation scripts to remove annotation data related to "subclassing".

yuanzhou and others added 5 commits November 1, 2023 13:49
…eLVOrgans

Add lymphatic vasculature (LV) to list of allowed multiple organs
…support for annotation related to "subclassing". Revise ERD and database generation scripts to remove annotation data related to "subclassing".
@kburke kburke changed the base branch from main to dev-integrate January 25, 2024 21:22
@yuanzhou
Copy link
Collaborator

@kburke when we test the changes out on DEV during redeployment, do you need to manually update the MySQL uuid database table schema by removing the ENTITY_CLASS_METADATA column and all its data at the same time? If so, we'll need to coordinate and make a backup first.

FYI @maxsibilla I'm a bit concerned when you redeploy uuid-api on SenNet DEV with the config and database updates, you may run into issues with the logging because the SenNet deployment doesn't forward the logs to CloudWatch.

@kburke
Copy link
Author

kburke commented Jan 31, 2024

@yuanzhou We do need to coordinate the MySQL changes with migrations. FWIW, it is more for the UPDATE command on existing data than the ALTER command, but I will do them all together. We can make a database backup to follow the correct process, though we are only making a simple value change to about 30 rows of data.

@yuanzhou yuanzhou merged commit 00b41b9 into dev-integrate Jan 31, 2024
2 checks passed
@yuanzhou yuanzhou deleted the karlburke/PublicationsWithoutSubclassing branch February 8, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants