Add refs.is_generated to distinguish references from source/generated by ghc #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrcek
force-pushed
the
jhrcek/renaming-constr-with-fields-2
branch
from
9173b1f to
dbaf56b
Compare
jhrcek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative approach to #73
Instead of dropping all the generated references altogether, we just introduce a boolean flag to refs table that stores True for generated references, and False for references coming from source code.
The overall intention is to fix the hls-rename-plugin bug whereby it incorrectly renames all record fields whenever you rename record constructor, because in HieAST all field selectors have a generated reference to the constructor.