Add Show instances for Command and Options #71
Conversation
jhrcek
force-pushed
the
jhrcek/show-command-options
branch
from
3727367 to
3c398d3
Compare
src/HieDb/Compat.hs
Outdated
| @@ -216,3 +217,8 @@ fieldNameSpace_maybe _ = Nothing | |||
| fieldName :: FastString -> NameSpace | |||
| fieldName _ = varName | |||
| #endif | |||
|
|
|||
| #if __GLASGOW_HASKELL__ < 902 | |||
| instance Show ModuleName where | |||
There was a problem hiding this comment.
I don't think we want to expose this orphan, it might conflict with other instances in ghcide etc.
There was a problem hiding this comment.
This instance used to be defined in HLS itself before it was removed as part of this "drop support for ghc 9.0" PR:
https://github.com/haskell/haskell-language-server/pull/3875/files#diff-380432f16b40730b2d63e7ec74a15219c0efa602f03c884837c9e27cf0cc655bL126-L129
Do you have ideas about how the show instance could be defined for ghc 9.0 in hiedb? Declaring it manually with moduleNameString "inlined" doesn't sound appealing..
Is it even worth it resolving that hls TODO or would it be better to just remove it?
A third option that comes to mind: since hls dropped ghc 9.0 support perhaps we could drop support for it in hiedb as well which would make this workaround unnecessary.
jhrcek
force-pushed
the
jhrcek/show-command-options
branch
from
3c398d3 to
4e61fcf
Compare
Found this TODO in hls repo:
https://github.com/haskell/haskell-language-server/blob/908db388190c8328e289a1019a033304e5e28ab9/ghcide/src/Development/IDE/Main.hs#L183-L185