Fix NameError for subscriptions with custom Type #468
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to initialize a GraphQL schema with a subscription returning a custom type, I experienced this error. It is easily fixed by properly wrapping the operation in the Resolver. I would appreciate a merge and maybe also a small update of the pip package.
Background:
get_type_hints
can't get the type hints for the wrapped method, because without knowing about the method it wraps the globalns can't be properly resolved and thus the return value is not found. This results in an error message similar to this one: