Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added total balance overall and activity for this month #3

Merged
merged 2 commits into from
Dec 5, 2019

Conversation

AlasdairH
Copy link
Contributor

Added in attributes for overall balance and activity for the current month. Please review and let me know if you think it fits!

Copy link
Owner

@wxt9861 wxt9861 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this looks great. Thank you for your contribution. Can you just change the one line before I merge it?

self.hass.data[DOMAIN_DATA]["total_balance"] = total_balance / 1000
_LOGGER.debug(
"Recieved data for: total balance: %s",
(total_balance),
Copy link
Owner

@wxt9861 wxt9861 Dec 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change line 150 to self.hass.data[DOMAIN_DATA]["total_balance"] so that the logger outputs balance in the same format as other values.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done as of the latest commit. Well spotted!

@wxt9861 wxt9861 merged commit 064cbe8 into wxt9861:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants