Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): solve disappearing checked state in ChoiceField and RadioGroup #328

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

lucas-contreras
Copy link
Collaborator

No description provided.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-328.dmoqt7vj2nim.amplifyapp.com

@cafrias cafrias changed the title fix: changed useEffect by useLayoutEffect in choise fix: changed useEffect by useLayoutEffect in choice Nov 15, 2023
@cafrias
Copy link
Collaborator

cafrias commented Nov 15, 2023

@lucas-contreras please rebase the commits, use only a single fix prefixed commit that explains the issue fixed (not the solution), remember this will be included in the CHANGELOG file.

Something like: fix(react): solve disappearing checked state in ChoiceField and RadioGroup

@lucas-contreras lucas-contreras changed the title fix: changed useEffect by useLayoutEffect in choice fix(react): solve disappearing checked state in ChoiceField and RadioGroup Nov 15, 2023
@cafrias cafrias merged commit 7e4cbbe into main Nov 17, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants