Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IconButton tooltips overlapping #2

Closed
cafrias opened this issue Aug 6, 2020 · 1 comment · Fixed by #4
Closed

IconButton tooltips overlapping #2

cafrias opened this issue Aug 6, 2020 · 1 comment · Fixed by #4

Comments

@cafrias
Copy link
Collaborator

cafrias commented Aug 6, 2020

Hey there! I have the current issue with IconButton components:

controls-tooltip

As you can see the tooltips are overlapping with the other buttons on the side panel. On a smaller breakpoint this is not a problem since this sidebar goes to the top:

controls-tooltip-sm

One suggestion would be to be able to tell the direction where the tooltip opens to, in this scenario opening to the right would be just fine.

@sh0ji sh0ji mentioned this issue Aug 7, 2020
@sh0ji
Copy link
Contributor

sh0ji commented Aug 7, 2020

I implemented a fix for this in #4. All components that can use tooltips now expose a tooltipProps prop that you can use to set a subset of the tooltip's props.

To fix the vertical toolbar issue, you should be able to do this:

<IconButton tooltipProps={{ placement: 'right' }} />

And you can also modify the hideDelay to reduce the length of time before the tooltips disappear. This defaults to 200 (ms) now to ensure that users can select the contents of the tooltip.

@sh0ji sh0ji closed this as completed in #4 Aug 7, 2020
sh0ji added a commit that referenced this issue Sep 19, 2024
sh0ji added a commit that referenced this issue Dec 11, 2024
* docs: make the beta warning more clear

* docs: restructure anatomy based on editorial feedback

* chore: revisions from session #2

* docs: deep edits to multiple choice guidelines

* docs: update multiple choice anatomy images

* chore: revise multiple choice description

* chore: remove redundant -pattern from filename

* chore: update link

* chore: autogen the pattern docs structure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants