Skip to content

Commit

Permalink
upgrade java style-check due to CVE-2019-9658 (apache#2817)
Browse files Browse the repository at this point in the history
  • Loading branch information
yzhliu authored and wweic committed Mar 20, 2019
1 parent 4892535 commit ded7159
Show file tree
Hide file tree
Showing 8 changed files with 7 additions and 9 deletions.
3 changes: 0 additions & 3 deletions jvm/conf/google_checks.xml
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,6 @@
<property name="tokens" value="LITERAL_TRY, LITERAL_FINALLY, LITERAL_IF, LITERAL_ELSE, LITERAL_SWITCH"/>
</module>
<module name="NeedBraces"/>
<module name="LeftCurly">
<property name="maxLineLength" value="100"/>
</module>
<module name="RightCurly"/>
<module name="RightCurly">
<property name="option" value="alone"/>
Expand Down
2 changes: 1 addition & 1 deletion jvm/core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
<version>6.12</version>
<version>[8.18,)</version>
</dependency>
</dependencies>
<executions>
Expand Down
2 changes: 1 addition & 1 deletion jvm/core/src/main/java/ml/dmlc/tvm/Base.java
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ private static void tryLoadLibraryXPU(String libname, String arch) throws Unsati

// helper function definitions
/**
* Check the return value of C API call
* Check the return value of C API call.
* <p>
* This function will raise exception when error occurs.
* Wrap every API call with this function
Expand Down
2 changes: 1 addition & 1 deletion jvm/core/src/main/java/ml/dmlc/tvm/Function.java
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ private static Function getGlobalFunc(String name, boolean isResident, boolean a
}

/**
* Initialize the function with handle
* Initialize the function with handle.
* @param handle the handle to the underlying function.
* @param isResident Whether this is a resident function in jvm
*/
Expand Down
1 change: 1 addition & 0 deletions jvm/core/src/main/java/ml/dmlc/tvm/Module.java
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ public void importModule(Module module) {
}

/**
* Get type key of the module.
* @return type key of the module.
*/
public String typeKey() {
Expand Down
2 changes: 1 addition & 1 deletion jvm/core/src/main/java/ml/dmlc/tvm/NDArrayBase.java
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public class NDArrayBase extends TVMValue {
}

/**
* Copy array to target
* Copy array to target.
* @param target The target array to be copied, must have same shape as this array.
* @return target
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public GraphModule setInput(String key, NDArray value) {
}

/**
* Set inputs to the module
* Set inputs to the module.
* @param key The input key.
* @param value The input value.
* @return self.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public class NativeServerLoop implements Runnable {
private final int sockFd;

/**
* Constructor for NativeServerLoop
* Constructor for NativeServerLoop.
* @param nativeSockFd native socket file descriptor.
*/
public NativeServerLoop(final int nativeSockFd) {
Expand Down

0 comments on commit ded7159

Please sign in to comment.