-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround for fixed elements inside transformed elements #106
Conversation
… align the tooltip against that parent
Could you introduce background about your thought? I see there is an new attribute |
@wwayne Yeah, sorry. The main idea is that the tooltip will scan it's own parent chain for the elements being transformed with css transform. If there is such element then the tooltip will be positioned relative to that element (cause the fixed elements are positioned relative to it's transformed parent and not relative to body). And I think it should be enabled by default. Actually I forgot why I did that new prop 😄 |
Sorry I've forgotten this... could you please resolve the conflict so that I can merge this in the future? |
# Conflicts: # dist/react-tooltip.min.js
Hmm it seems I'v did something wrong. There are some strange changes after building. Maybe this caused by newer versions of babel and browserify. |
@nd0ut Never mind, I will fix it. But I need to check the code first... anyway, thanks for your PR |
@nd0ut Thanks, will do some modification before next release 👍 |
Ref #16