Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for fixed elements inside transformed elements #106

Merged
merged 5 commits into from
Jun 14, 2016

Conversation

nd0ut
Copy link
Contributor

@nd0ut nd0ut commented May 25, 2016

Ref #16

@wwayne
Copy link
Collaborator

wwayne commented May 31, 2016

Could you introduce background about your thought? I see there is an new attribute checkParentTransform, and what you use this attribute to do?

@nd0ut
Copy link
Contributor Author

nd0ut commented Jun 1, 2016

@wwayne Yeah, sorry. The main idea is that the tooltip will scan it's own parent chain for the elements being transformed with css transform. If there is such element then the tooltip will be positioned relative to that element (cause the fixed elements are positioned relative to it's transformed parent and not relative to body).

And I think it should be enabled by default. Actually I forgot why I did that new prop 😄

@danbrianwhite
Copy link

@wwayne Any updates on merging this pull request? The update by @nd0ut fixes an issue I have with tooltip position in a fixed element.

@wwayne
Copy link
Collaborator

wwayne commented Jun 7, 2016

Sorry I've forgotten this... could you please resolve the conflict so that I can merge this in the future?

nd0ut added 2 commits June 7, 2016 17:40
# Conflicts:
#	dist/react-tooltip.min.js
@nd0ut
Copy link
Contributor Author

nd0ut commented Jun 7, 2016

Hmm it seems I'v did something wrong. There are some strange changes after building. Maybe this caused by newer versions of babel and browserify.

@wwayne
Copy link
Collaborator

wwayne commented Jun 7, 2016

@nd0ut Never mind, I will fix it. But I need to check the code first... anyway, thanks for your PR

@wwayne
Copy link
Collaborator

wwayne commented Jun 14, 2016

@nd0ut Thanks, will do some modification before next release 👍

@wwayne wwayne merged commit e0ee73d into ReactTooltip:master Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants