finagle (fix): Properly set http method and path parameters in convertToFinagleRequest

[yuokada]

Overview

• Currently, convertToFinagleRequest doesn't respect Method, request path and etc

[codecov]

Codecov Report

Merging #3179 (e6c96c7) into main (a6ec410) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3179      +/-   ##
==========================================
+ Coverage   82.88%   82.89%   +0.01%     
==========================================
  Files         350      350              
  Lines       14743    14745       +2     
  Branches     2447     2401      -46     
==========================================
+ Hits        12219    12223       +4     
+ Misses       2524     2522       -2     

Files Changed	Coverage Δ
...in/scala/wvlet/airframe/http/finagle/package.scala	85.29% <100.00%> (+2.21%)	⬆️

... and 2 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6ec410...e6c96c7. Read the comment docs.

[xerial]

I thought the path can contain the query string ?bar=true&baz=1234. Does it need to be set as params?

[yuokada]

Does it need to be set as params?

IIRC, there is a way to set a path with query parameters. If the way to get a path with a query string exists, I would use a simpler way.
Considering the duplication of parameters, value encoding issues and etc, I adopted the above way.

---

In my understanding, path doesn't contain a query string.
And, according to the wikipedia, behavior of the uri parameter in the case class, Request , is different with the definition of URI in the wikipedia.
I was actually confused with it before.

airframe/airframe-http/src/main/scala/wvlet/airframe/http/HttpMessage.scala

Lines 207 to 214 in 8ef23a3

	case class Request(
	method: String = HttpMethod.GET,
	// Path and query string beginning from "/"
	uri: String = "/",
	header: HttpMultiMap = HttpMultiMap.empty,
	message: Message = EmptyMessage,
	remoteAddress: Option[ServerAddress] = None
	) extends HttpMessage[Request] {