Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc (breaking): Use RxHttpFilter as Sync/AsyncClient filter type #3141

Merged
merged 11 commits into from
Sep 11, 2023
Merged

Conversation

xerial
Copy link
Member

@xerial xerial commented Aug 15, 2023

  • Add RPC filter tests
  • Fix async handler chain
  • Fix sync handler chain

@github-actions github-actions bot added the bug label Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #3141 (7787d71) into main (d1ce2e0) will decrease coverage by 0.03%.
The diff coverage is 90.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3141      +/-   ##
==========================================
- Coverage   82.74%   82.71%   -0.03%     
==========================================
  Files         355      355              
  Lines       14777    14798      +21     
  Branches     2463     2451      -12     
==========================================
+ Hits        12227    12240      +13     
- Misses       2550     2558       +8     
Files Changed Coverage Δ
...wvlet/airframe/http/client/HttpClientFactory.scala 66.66% <ø> (-3.34%) ⬇️
.../wvlet/airframe/http/client/HttpClientFilter.scala 0.00% <0.00%> (-100.00%) ⬇️
...scala/wvlet/airframe/http/client/HttpClients.scala 84.33% <ø> (ø)
.../wvlet/airframe/http/client/HttpClientConfig.scala 58.62% <50.00%> (+1.95%) ⬆️
.../main/scala/wvlet/airframe/http/RxHttpFilter.scala 72.72% <66.66%> (-2.28%) ⬇️
...scala/wvlet/airframe/http/client/AsyncClient.scala 100.00% <100.00%> (ø)
.../scala/wvlet/airframe/http/client/SyncClient.scala 97.36% <100.00%> (+0.39%) ⬆️
...frame-rx/src/main/scala/wvlet/airframe/rx/Rx.scala 82.17% <100.00%> (-0.83%) ⬇️
...rx/src/main/scala/wvlet/airframe/rx/RxRunner.scala 92.28% <100.00%> (+0.17%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1ce2e0...7787d71. Read the comment docs.

@xerial xerial added breaking Breaking changes and removed bug labels Sep 11, 2023
@xerial xerial changed the title rpc (fix): Fix http client filter order rpc (breaking): Use RxHttpFilter as Sync/AsyncClient filter type Sep 11, 2023
@xerial xerial marked this pull request as ready for review September 11, 2023 05:23
@xerial xerial enabled auto-merge (squash) September 11, 2023 23:17
@xerial xerial merged commit 86fbc24 into main Sep 11, 2023
@xerial xerial deleted the rpc-error branch September 11, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant