Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc (fix): Set missing Accept header for RPC requests #3087

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

xerial
Copy link
Member

@xerial xerial commented Aug 3, 2023

Fixes #3083

@github-actions github-actions bot added the bug label Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #3087 (3e431d0) into master (ed1faeb) will increase coverage by 0.02%.
The diff coverage is 85.71%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3087      +/-   ##
==========================================
+ Coverage   82.84%   82.86%   +0.02%     
==========================================
  Files         349      349              
  Lines       14675    14681       +6     
  Branches     2498     2487      -11     
==========================================
+ Hits        12157    12165       +8     
+ Misses       2518     2516       -2     
Files Changed Coverage Δ
.../wvlet/airframe/http/client/HttpClientConfig.scala 53.33% <50.00%> (-0.24%) ⬇️
...wvlet/airframe/http/client/HttpClientFactory.scala 60.00% <100.00%> (+22.50%) ⬆️
...scala/wvlet/airframe/http/client/HttpClients.scala 89.07% <100.00%> (+0.09%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed1faeb...3e431d0. Read the comment docs.

@xerial xerial merged commit 5a51958 into master Aug 3, 2023
@xerial xerial deleted the fix-rpc-accept-header branch August 3, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rpc: Accept header is not properly set with js HTTP client
1 participant