MCP-5632 - Added MarshallJSON and UnMarshallJSON to marshal private a… #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttributes for MediaPlaylist structure. This is needed fo Master Controller code.
devangvdesai
approved these changes
May 7, 2020
There was a problem hiding this comment.
@cnguyenWurl - it looks good to me and straightforward changes in terms of impact (since we are adding 2 new methods). However, since this impacts channelworker, hlsconnector (I'm not sure if Rokudirectfeeder also uses m3u8), I'll tag @ramabb in here as well, so he is aware of the changes. And once we merge the changes the other libraries/repositories dependent on m3u8 should pull these changes and just have a basic test to make sure there are no issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements MarshalJSON and UnMarshalJSON to marshal private parameters in MasterPlaylist