Use configured timeout value when requesting robots.txt files. #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please reroll this PR in the new organisation here: https://github.com/linkcheck/linkchecker/pulls see #686 for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a remote server is not responding, we have 2 issues.
requests.exceptions.Timeoutis not thrown. Instead we get arequests.exceptions.RequestException, which does not abort the link check. So we still have to wait for the link check to timeout before moving on.This patch uses the configured timeout value for robots.txt requests, which will throw
requests.exceptions.Timeoutand abort the current link check if the remote host does not respond after the timeout .