Skip to content
This repository has been archived by the owner on May 18, 2021. It is now read-only.

REBASE: Re-structure user configuration and add more dashboards based on #69 #75

Merged
merged 8 commits into from
Mar 11, 2021
Merged

REBASE: Re-structure user configuration and add more dashboards based on #69 #75

merged 8 commits into from
Mar 11, 2021

Conversation

fussel178
Copy link
Member

@fussel178 fussel178 commented Mar 10, 2021 •
edited
Loading

Features

closes #69
closes #67

@fussel178 fussel178 added enhancement New feature or request widget Everything related to Widgets labels Mar 10, 2021
@fussel178 fussel178 requested a review from pklaschka March 10, 2021 22:37
@fussel178 fussel178 self-assigned this Mar 10, 2021
pklaschka
pklaschka approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@pklaschka pklaschka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fussel178 fussel178 requested a review from pklaschka March 11, 2021 13:28
pklaschka
pklaschka suggested changes Mar 11, 2021
View reviewed changes
Copy link
Member

@pklaschka pklaschka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution. I will be honest: I don't really like the names in the status light and think they may be a bit confusing, so let's maybe brainstorm about other possibilities there. Other than that, it looks good.

src/widgets/gps-details-widget/widget.tsx Outdated Show resolved Hide resolved
@fussel178 fussel178 requested a review from pklaschka March 11, 2021 21:32
pklaschka
pklaschka approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@pklaschka pklaschka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fussel178 fussel178 merged commit 4cfcaa8 into main Mar 11, 2021
@fussel178 fussel178 deleted the feat/model/user-dashboards branch March 11, 2021 21:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pklaschka pklaschka pklaschka approved these changes

Assignees

@fussel178 fussel178

Labels
enhancement New feature or request widget Everything related to Widgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add dashboards for different program states Adopt to new message definitions
2 participants
@fussel178 @pklaschka