Skip to content
This repository has been archived by the owner on May 18, 2021. It is now read-only.

REBASE: feat(widget): Improve graph widget #68

Merged
merged 5 commits into from
Mar 10, 2021
Merged

REBASE: feat(widget): Improve graph widget #68

merged 5 commits into from
Mar 10, 2021

Conversation

fussel178
Copy link
Member

@fussel178 fussel178 commented Mar 10, 2021 •
edited
Loading

Screenshot_20210310_001538

Features

  • Graph widget
    • optional unit definable for each data set which is displayed in the graph legend and the tooltip
    • the y-axis is now customizable via the domain and scale prop to define upper and lower bounds and the scaling of the axis
    • make more widget props optional to reduce user configuration
    • improve documentation of widget props
    • clean up codebase
    • improve widget performance by caching non changing part
  • Update user configuration
    • add and update all message data types to be conform with new (and hopefully final) data message scheme
    • add useful units to data sets in all graph widgets
    • reduce size of configuration because more props are optional
    • replace amplitude widget with graph widget

Fixes

  • fix map widget to be conform with GPS data message type

Updates

  • Update to framework version v0.11.2

references #67

Cheers 🛰️

fussel178 added 5 commits March 9, 2021 13:18
@fussel178
fix(widget): Fix map widget to be conform with GPS data message type
5de6bc9
@fussel178
chore(deps): Update to framework version v0.11.2
79a208a
@fussel178
feat(widget): Improve graph widget
a97dc3e 
- optional unit definable for each data set which is displayed in the graph legend and the tooltip
- the y-axis is now customizable via the `domain` and `scale` prop to define upper and lower bounds and the scaling of the axis
- make more widget props optional to reduce user configuration
- improve documentation of widget props
- clean up codebase
- improve widget performance by caching non changing part
@fussel178
feat(model): Update user configuration
69271e4 
- add and update all message data types to be conform with new (and hopefully final) data message scheme
- add useful units to data sets in all graph widgets
- reduce size of configuration because more props are optional
- replace amplitude widget with graph widget
@fussel178
fix(plugin): Update mock server plugin to be conform with new data me…
26deded 
…ssage format
@fussel178 fussel178 added enhancement New feature or request widget Everything related to Widgets labels Mar 10, 2021
@fussel178 fussel178 requested a review from pklaschka March 10, 2021 00:01
@fussel178 fussel178 self-assigned this Mar 10, 2021
@fussel178 fussel178 mentioned this pull request Mar 10, 2021
Closed
13 tasks
pklaschka
pklaschka approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@pklaschka pklaschka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 👍 ! Thank you for your contribution.

@fussel178 fussel178 merged commit 0daccce into main Mar 10, 2021
@fussel178 fussel178 deleted the feat/widget/graph-widget branch March 10, 2021 01:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pklaschka pklaschka pklaschka approved these changes

Assignees

@fussel178 fussel178

Labels
enhancement New feature or request widget Everything related to Widgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fussel178 @pklaschka