Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release automation #7

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Update release automation #7

merged 1 commit into from
Dec 11, 2024

Conversation

pklaschka
Copy link
Member

@pklaschka pklaschka commented Dec 11, 2024 •
edited by github-actions bot
Loading

@pklaschka pklaschka added 🚀 deployment Pull request updating the pipeline 🏃 github_actions Pull requests that update Github_actions code labels Dec 11, 2024
@pklaschka pklaschka requested a review from fussel178 December 11, 2024 12:35
@pklaschka pklaschka self-assigned this Dec 11, 2024
@Copilot Copilot bot review requested due to automatic review settings December 11, 2024 12:35
Copilot
Copilot AI reviewed Dec 11, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 5 changed files in this pull request and generated no suggestions.

Files not reviewed (3)
  • .github/workflows/jsr-publish.yml: Language not supported
  • deno.json: Language not supported
  • version.json: Language not supported
Comments skipped due to low confidence (2)

.github/workflows/release.yml:103

  • Changing the push condition to always push could lead to unintended behavior, especially if the workflow runs on pull requests. Consider adding a condition to avoid pushing on pull requests.
push: true

.github/workflows/release.yml:54

  • Ensure that the behavior of updating the version in deno.json and publishing is covered by tests to avoid potential issues.
run: deno publish --allow-dirty
fussel178
fussel178 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@fussel178 fussel178 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hope, it works 🙈

@pklaschka pklaschka merged commit 6c9678c into main Dec 11, 2024
2 checks passed
@pklaschka pklaschka deleted the release-automation branch December 11, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@fussel178 fussel178 fussel178 approved these changes

Assignees

@pklaschka pklaschka

Labels
🚀 deployment Pull request updating the pipeline 🏃 github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pklaschka @fussel178