Skip to content

Commit

Permalink
fix: dll json (package nesting causes mismatches)
Browse files Browse the repository at this point in the history
  • Loading branch information
zhaoqi15 committed Dec 8, 2021
1 parent f5ac458 commit 695e8d4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Further split the React Native code based on Metro build to improve performance,

| metro version | metro-code-split version |
| :-----------: | :----------------------: |
| 0.64.0 - 0.66.0 | 0.1.x |
| 0.64.0 - 0.66.2 | 0.1.x |

## How to use it?

Expand Down Expand Up @@ -118,6 +118,5 @@ Further split the React Native code based on Metro build to improve performance,

## TODO

- cacheStores: [], // concurrent build cache issues https://github.com/facebook/metro/issues/331
- source map support
- ts refactor
2 changes: 1 addition & 1 deletion src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ class MetroCodeSplit {
BuildType.DllJson !== this.bundleOutputInfo.name && log('warning: failed to load the dllRefPath correctly! are you setting the "dll.referenceDir" correctly?', 'yellow')
}
// inertia method
this.isDllPath = p => commonPaths.includes(replacePath(p))
this.isDllPath = p => commonPaths.some(v => p.endsWith(v) || v.endsWith(p))
return this.isDllPath(p)
}

Expand Down

0 comments on commit 695e8d4

Please sign in to comment.